Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libuv: expand the steaming pile of unsandboxable tests #211896

Merged
merged 1 commit into from Jan 23, 2023
Merged

libuv: expand the steaming pile of unsandboxable tests #211896

merged 1 commit into from Jan 23, 2023

Conversation

ghost
Copy link

@ghost ghost commented Jan 21, 2023

Description of changes

I can't reproduce OfBorg's failure on my own hardware:

https://logs.nix.ci/?key=nixos/nixpkgs.209870&attempt_id=0d5c4dad-7738-4204-ad65-25f6ab51a5cf

LibUV tests are ultra-flaky.

Things done

@ghost ghost mentioned this pull request Jan 21, 2023
4 tasks
@ofborg ofborg bot requested a review from cstrahan January 21, 2023 09:48
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ labels Jan 21, 2023
@risicle
Copy link
Contributor

risicle commented Jan 21, 2023

This is happening on my nixos x86_64 machine too, so I don't think it's restricted to aarch64.

@risicle
Copy link
Contributor

risicle commented Jan 21, 2023

...along with tcp_bind6_error_addrinuse too

@ghost ghost requested review from Artturin and removed request for cstrahan January 21, 2023 21:05
@ofborg ofborg bot requested a review from cstrahan January 21, 2023 21:56
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 21, 2023
Copy link
Member

@sternenseemann sternenseemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran into this on armv7l-linux as well.

@Artturin
Copy link
Member

should target staging

@risicle
Copy link
Contributor

risicle commented Jan 22, 2023

Hmm for quite a few people it's breaking master though, so making them wait for the next staging cycle seems kinda mean.

@ghost ghost marked this pull request as draft January 22, 2023 19:52
@ghost ghost changed the base branch from master to staging January 22, 2023 19:53
@ghost ghost marked this pull request as ready for review January 22, 2023 19:54
@Artturin
Copy link
Member

fix'd up the commits

@Artturin Artturin merged commit b2840f4 into NixOS:staging Jan 23, 2023
@ghost ghost deleted the pr/libuv/tests branch January 23, 2023 19:13
@bobby285271
Copy link
Member

🤔 I ran into this when doing a staging-22.11 PR (#214874), shall we do a backport?

https://logs.nix.ci/?key=nixos/nixpkgs.214874&attempt_id=f696d55a-bec8-4b8a-8988-84cf1fa2bd80

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

Successfully created backport PR for staging-22.11:

@winterqt
Copy link
Member

Funnily enough, this has nothing to do with flakiness. It's a kernel bug!

See https://utcc.utoronto.ca/~cks/space/blog/linux/KernelBindBugIn6016 (thanks vcunat for pointing this out).

@ghost
Copy link
Author

ghost commented Feb 13, 2023

Funnily enough, this has nothing to do with flakiness. It's a kernel bug!

See https://utcc.utoronto.ca/~cks/space/blog/linux/KernelBindBugIn6016 (thanks vcunat for pointing this out).

Ah, that explains why I couldn't reproduce OfBorg's failure. None of my machines run 6.x kernels yet.

@winterqt
Copy link
Member

@amjoseph-nixpkgs What 5.15 (presumably) revision do your machines run? It seems that it affects recent 5.15 versions as well, see https://lore.kernel.org/all/EF8A45D0-768A-4CD5-9A8A-0FA6E610ABF7@winter.cafe/.

@ghost
Copy link
Author

ghost commented Feb 15, 2023

Looks like you replied as I was editing away the stupidity of my first response :)

@erikarvstedt
Copy link
Member

erikarvstedt commented Feb 16, 2023

I just helped a user track down this issue, here's some data from the debugging, if it helps (I didn't come across this PR right away):

uname -r Test failure appears
5.15.91 Always
5.15.0-60-generic Never
5.15.86 Never
Repro script
# Use a separate, temporary Nix store, so we can debug derivations that are already
# available in the main store
store="--store /tmp/store"
sudo rm -rf /tmp/store

# Fetch all build deps from the binary cache
drv="github:NixOS/nixpkgs/3954218cf613eba8e0dcefa9abe337d26bc48fd0#libuv"
nix print-dev-env $store $drv --substitute >/dev/null

# Build just the drv, without substitution
nix build --no-link --print-out-paths -L $store --no-substitute $drv

# Cleanup
sudo rm -rf /tmp/store

@winterqt
Copy link
Member

winterqt commented Feb 16, 2023

Hi @erikarvstedt, I determined that this was a kernel regression in 5.15 starting with 5.15.88, see the LKML thread I linked above: https://lore.kernel.org/all/EF8A45D0-768A-4CD5-9A8A-0FA6E610ABF7@winter.cafe/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants